mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-07 11:14:28 +02:00
e9d04ecfc1
* feat(labels): add issue label CRUD + attach/detach handlers (#1191) The issue_label and issue_to_label tables were scaffolded in 001_init.up.sql but never wired to any code path. This commit ships the backend for #1191: - Migration 048: adds created_at/updated_at timestamps + workspace-scoped case-insensitive unique index on label names - sqlc queries for label CRUD + issue<->label attach/detach + batch list (ListLabelsByIssueIDs for board/list views) - HTTP handlers: /api/labels CRUD, /api/issues/{id}/labels attach/detach - Protocol events: label:{created,updated,deleted} + issue_labels:changed - Handler tests covering CRUD, duplicate-name conflict, invalid-color, attach/detach idempotency, and cross-workspace isolation * feat(cli): add label and issue label subcommands (#1191) - multica label {list,get,create,update,delete} - multica issue label {list,add,remove} Both follow existing CLI conventions (JSON/table output, flag shapes) and exercise the /api/labels endpoints shipped in the previous commit. * feat(web): add labels UI — picker with inline create + management dialog (#1191) Exposes the backend label feature to users via the existing issue-detail sidebar. - `@multica/core/types/label` — Label, CreateLabelRequest, UpdateLabelRequest, plus response envelopes - `@multica/core/api/client` — 8 methods for label CRUD and issue↔label attach/detach - `@multica/core/labels` — labelKeys, queryOptions, and mutation hooks with optimistic updates (matches the project/ module layout) - WS event type literals extended for label:{created,updated,deleted} and issue_labels:changed - `views/labels/label-chip.tsx` — colored pill; uses relative luminance (ITU-R BT.601) to pick #111827 or #f9fafb text so chips stay readable on both pastel and saturated backgrounds - `views/issues/components/pickers/label-picker.tsx` - Multi-select combobox in the issue sidebar - When 0 labels: "Add label" trigger - When 1+ labels: the chips themselves are the trigger; × on each chip detaches without opening the picker - Inline create: typing a new name + Enter creates with a hash-derived color and attaches in one motion (matches Linear/GitHub) - "Manage labels…" footer opens a dialog containing the full workspace panel — users never leave the issue context to rename/recolor/delete - `views/issues/components/labels-panel.tsx` — workspace labels manager. Single-row create form (color swatch + name + Add button). Each label row supports inline rename + recolor + delete (with confirm dialog). Color input uses the browser's native picker for full-gamut access — no preset palette clutter. - `PropRow label="Labels"` added to the issue-detail sidebar below Project Labels are issue metadata everyone uses — not admin configuration. Putting them in Settings next to destructive workspace actions misframed them; adding a top-level nav entry or a sibling tab to the Issues page added surface area that wasn't earning its keep for a feature users touch occasionally. Keeping management in a dialog launched from the picker itself keeps users in their issue context and matches how GitHub handles label editing from the label selector.
69 lines
2.2 KiB
SQL
69 lines
2.2 KiB
SQL
-- name: ListLabels :many
|
|
SELECT * FROM issue_label
|
|
WHERE workspace_id = $1
|
|
ORDER BY LOWER(name) ASC;
|
|
|
|
-- name: GetLabel :one
|
|
SELECT * FROM issue_label
|
|
WHERE id = $1 AND workspace_id = $2;
|
|
|
|
-- name: CreateLabel :one
|
|
INSERT INTO issue_label (workspace_id, name, color)
|
|
VALUES ($1, $2, $3)
|
|
RETURNING *;
|
|
|
|
-- name: UpdateLabel :one
|
|
UPDATE issue_label SET
|
|
name = COALESCE(sqlc.narg('name'), name),
|
|
color = COALESCE(sqlc.narg('color'), color),
|
|
updated_at = now()
|
|
WHERE id = $1 AND workspace_id = $2
|
|
RETURNING *;
|
|
|
|
-- name: DeleteLabel :one
|
|
-- :one RETURNING id so the handler distinguishes pgx.ErrNoRows (→ 404) from
|
|
-- infrastructure errors (→ 500), and avoids a TOCTOU precheck.
|
|
DELETE FROM issue_label
|
|
WHERE id = $1 AND workspace_id = $2
|
|
RETURNING id;
|
|
|
|
-- name: AttachLabelToIssue :exec
|
|
-- Workspace-guarded INSERT: the WHERE EXISTS clauses ensure both the issue
|
|
-- and the label belong to the given workspace. A future caller that forgets
|
|
-- handler-level prechecks still cannot attach labels across workspaces.
|
|
INSERT INTO issue_to_label (issue_id, label_id)
|
|
SELECT sqlc.arg('issue_id')::uuid, sqlc.arg('label_id')::uuid
|
|
WHERE EXISTS (
|
|
SELECT 1 FROM issue i
|
|
WHERE i.id = sqlc.arg('issue_id')::uuid
|
|
AND i.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
)
|
|
AND EXISTS (
|
|
SELECT 1 FROM issue_label l
|
|
WHERE l.id = sqlc.arg('label_id')::uuid
|
|
AND l.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
)
|
|
ON CONFLICT DO NOTHING;
|
|
|
|
-- name: DetachLabelFromIssue :exec
|
|
-- Workspace-guarded DELETE: only deletes if the issue is in the given
|
|
-- workspace. Mirror of the attach query.
|
|
DELETE FROM issue_to_label
|
|
WHERE issue_id = sqlc.arg('issue_id')::uuid
|
|
AND label_id = sqlc.arg('label_id')::uuid
|
|
AND EXISTS (
|
|
SELECT 1 FROM issue i
|
|
WHERE i.id = sqlc.arg('issue_id')::uuid
|
|
AND i.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
);
|
|
|
|
-- name: ListLabelsByIssue :many
|
|
-- Workspace filter at the SQL layer (mirrors GetProjectInWorkspace). Any caller
|
|
-- that passes the wrong workspace gets an empty list rather than leaking labels.
|
|
SELECT l.*
|
|
FROM issue_label l
|
|
JOIN issue_to_label il ON il.label_id = l.id
|
|
WHERE il.issue_id = sqlc.arg('issue_id')::uuid
|
|
AND l.workspace_id = sqlc.arg('workspace_id')::uuid
|
|
ORDER BY LOWER(l.name) ASC;
|