Files
multica/server/pkg/db/queries/issue.sql
Naiyuan Qing 0127d6a258 fix(issues): address MUL-2314 reviewer notes 1-4
#1 sort default: missing sort_by, unknown sort_by, and illegal
sort_direction all collapse to created_at DESC, id DESC (was ASC).
Order-asserting test cases added for every degenerate input.

#2 onboarding position: extract nextIssuePosition helper. Welcome
issue + sub-issues + the existing CreateIssue path all route through
it instead of inheriting Go's Position=0 default. This consolidates
the three create call-sites so a fourth path cannot regress.

#3 rebalance hot path: replace full-bucket scan with a neighbor-only
SQL query (GetIssueNeighborGap) used by MaybeEnqueueRebalance. Hot
path stays O(1); worker still does the full bucket scan when actually
rebalancing. Bucket-edge issues use COALESCE sentinels so missing
neighbours never trigger spurious rebalances.

#4 migration: up is now order-preserving (position ASC, created_at
DESC, id DESC) and idempotent (skips buckets that are already sparse).
down drops only the index; data restore is per runbook snapshot so a
destructive UPDATE issue SET position = 0 cannot wipe drag edits.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
2026-05-18 13:58:45 +08:00

209 lines
8.5 KiB
SQL

-- name: ListIssues :many
SELECT id, workspace_id, title, description, status, priority,
assignee_type, assignee_id, creator_type, creator_id,
parent_issue_id, position, start_date, due_date, created_at, updated_at, number, project_id
FROM issue
WHERE workspace_id = $1
AND (sqlc.narg('status')::text IS NULL OR status = sqlc.narg('status'))
AND (sqlc.narg('priority')::text IS NULL OR priority = sqlc.narg('priority'))
AND (sqlc.narg('assignee_id')::uuid IS NULL OR assignee_id = sqlc.narg('assignee_id'))
AND (sqlc.narg('assignee_ids')::uuid[] IS NULL OR assignee_id = ANY(sqlc.narg('assignee_ids')::uuid[]))
AND (sqlc.narg('creator_id')::uuid IS NULL OR creator_id = sqlc.narg('creator_id'))
AND (sqlc.narg('project_id')::uuid IS NULL OR project_id = sqlc.narg('project_id'))
ORDER BY position ASC, created_at DESC
LIMIT $2 OFFSET $3;
-- name: GetIssue :one
SELECT * FROM issue
WHERE id = $1;
-- name: GetIssueInWorkspace :one
SELECT * FROM issue
WHERE id = $1 AND workspace_id = $2;
-- name: CreateIssue :one
INSERT INTO issue (
workspace_id, title, description, status, priority,
assignee_type, assignee_id, creator_type, creator_id,
parent_issue_id, position, start_date, due_date, number, project_id
) VALUES (
$1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15
) RETURNING *;
-- name: GetIssueByNumber :one
SELECT * FROM issue
WHERE workspace_id = $1 AND number = $2;
-- name: UpdateIssue :one
UPDATE issue SET
title = COALESCE(sqlc.narg('title'), title),
description = COALESCE(sqlc.narg('description'), description),
status = COALESCE(sqlc.narg('status'), status),
priority = COALESCE(sqlc.narg('priority'), priority),
assignee_type = sqlc.narg('assignee_type'),
assignee_id = sqlc.narg('assignee_id'),
position = COALESCE(sqlc.narg('position'), position),
start_date = sqlc.narg('start_date'),
due_date = sqlc.narg('due_date'),
parent_issue_id = sqlc.narg('parent_issue_id'),
project_id = sqlc.narg('project_id'),
updated_at = now()
WHERE id = $1
RETURNING *;
-- name: UpdateIssueStatus :one
UPDATE issue SET
status = $2,
updated_at = now()
WHERE id = $1
RETURNING *;
-- name: CreateIssueWithOrigin :one
INSERT INTO issue (
workspace_id, title, description, status, priority,
assignee_type, assignee_id, creator_type, creator_id,
parent_issue_id, position, start_date, due_date, number, project_id,
origin_type, origin_id
) VALUES (
$1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15,
sqlc.narg('origin_type'), sqlc.narg('origin_id')
) RETURNING *;
-- name: LockIssueDuplicateKey :exec
SELECT pg_advisory_xact_lock(hashtextextended($1::text, 0));
-- name: FindActiveDuplicateIssue :one
SELECT * FROM issue
WHERE workspace_id = $1
AND status NOT IN ('done', 'cancelled')
AND project_id IS NOT DISTINCT FROM $2::uuid
AND parent_issue_id IS NOT DISTINCT FROM $3::uuid
AND lower(btrim(regexp_replace(title, '[[:space:]]+', ' ', 'g'))) = $4
ORDER BY created_at ASC
LIMIT 1;
-- name: DeleteIssue :exec
DELETE FROM issue WHERE id = $1;
-- name: ListOpenIssues :many
SELECT id, workspace_id, title, description, status, priority,
assignee_type, assignee_id, creator_type, creator_id,
parent_issue_id, position, start_date, due_date, created_at, updated_at, number, project_id
FROM issue
WHERE workspace_id = $1
AND status NOT IN ('done', 'cancelled')
AND (sqlc.narg('priority')::text IS NULL OR priority = sqlc.narg('priority'))
AND (sqlc.narg('assignee_id')::uuid IS NULL OR assignee_id = sqlc.narg('assignee_id'))
AND (sqlc.narg('assignee_ids')::uuid[] IS NULL OR assignee_id = ANY(sqlc.narg('assignee_ids')::uuid[]))
AND (sqlc.narg('creator_id')::uuid IS NULL OR creator_id = sqlc.narg('creator_id'))
AND (sqlc.narg('project_id')::uuid IS NULL OR project_id = sqlc.narg('project_id'))
ORDER BY position ASC, created_at DESC;
-- name: CountIssues :one
SELECT count(*) FROM issue
WHERE workspace_id = $1
AND (sqlc.narg('status')::text IS NULL OR status = sqlc.narg('status'))
AND (sqlc.narg('priority')::text IS NULL OR priority = sqlc.narg('priority'))
AND (sqlc.narg('assignee_id')::uuid IS NULL OR assignee_id = sqlc.narg('assignee_id'))
AND (sqlc.narg('assignee_ids')::uuid[] IS NULL OR assignee_id = ANY(sqlc.narg('assignee_ids')::uuid[]))
AND (sqlc.narg('creator_id')::uuid IS NULL OR creator_id = sqlc.narg('creator_id'))
AND (sqlc.narg('project_id')::uuid IS NULL OR project_id = sqlc.narg('project_id'));
-- name: ListChildIssues :many
SELECT * FROM issue
WHERE parent_issue_id = $1
ORDER BY position ASC, created_at DESC;
-- name: GetMinIssuePosition :one
-- Returns the smallest `position` value in a (workspace_id, status) bucket,
-- defaulting to 1.0 for an empty bucket so the first new issue lands at 0.0
-- (`min - 1.0`). New issues are written with `min - 1.0` to keep "newest at
-- top" semantics under the legacy `position ASC, created_at DESC` ordering.
SELECT COALESCE(MIN(position), 1.0)::float8 AS min_position
FROM issue
WHERE workspace_id = $1 AND status = $2;
-- name: ListIssuePositionsByBucket :many
-- Used by the rebalance worker. Returns every issue in a (workspace_id,
-- status) bucket ordered by current `position ASC, created_at DESC, id DESC`
-- so the worker can deterministically re-space them with sparse float values.
SELECT id, position, created_at
FROM issue
WHERE workspace_id = $1 AND status = $2
ORDER BY position ASC, created_at DESC, id DESC;
-- name: GetIssueNeighborGap :one
-- Hot-path query used by MaybeEnqueueRebalance: returns the largest position
-- strictly less than @target_position (prev) and the smallest position strictly
-- greater than @target_position (next) within the same (workspace_id, status)
-- bucket. Bucket-edge issues have no prev or no next; we COALESCE the missing
-- side to (target ± 1.0) so the computed gap is always finite and large (= 1.0,
-- well above any plausible rebalance threshold), which means edge drags never
-- trigger a rebalance — correct, because there is no precision pressure on the
-- side without a neighbour. Backed by idx_issue_workspace_status_position, so
-- both subqueries are bounded-cost index seeks regardless of bucket size.
SELECT
COALESCE(
(SELECT MAX(i1.position) FROM issue i1
WHERE i1.workspace_id = @workspace_id AND i1.status = @status AND i1.position < @target_position),
@target_position::float8 - 1.0
)::float8 AS prev_position,
COALESCE(
(SELECT MIN(i2.position) FROM issue i2
WHERE i2.workspace_id = @workspace_id AND i2.status = @status AND i2.position > @target_position),
@target_position::float8 + 1.0
)::float8 AS next_position;
-- name: UpdateIssuePositionOnly :exec
-- Worker-only: rewrite a single issue's `position` without bumping
-- `updated_at`. Going through the full UpdateIssue mutation would broadcast
-- `issue:updated` for every row, defeating the rebalance event's purpose.
UPDATE issue SET position = $2 WHERE id = $1;
-- name: GetIssueByOrigin :one
-- Finds the issue stamped with a specific (origin_type, origin_id) pair.
-- Used by quick-create completion to deterministically locate the issue
-- produced by a given agent_task_queue.id — robust against concurrent
-- issue creates by the same agent (assignment task + quick-create both
-- running with max_concurrent_tasks > 1).
SELECT * FROM issue
WHERE workspace_id = $1
AND origin_type = $2
AND origin_id = $3
LIMIT 1;
-- name: CountCreatedIssueAssignees :many
-- Count assignees on issues created by a specific user.
SELECT
assignee_type,
assignee_id,
COUNT(*)::bigint as frequency
FROM issue
WHERE workspace_id = $1
AND creator_id = $2
AND creator_type = 'member'
AND assignee_type IS NOT NULL
AND assignee_id IS NOT NULL
GROUP BY assignee_type, assignee_id;
-- name: ChildIssueProgress :many
SELECT parent_issue_id,
COUNT(*)::bigint AS total,
COUNT(*) FILTER (WHERE status IN ('done', 'cancelled'))::bigint AS done
FROM issue
WHERE workspace_id = $1
AND parent_issue_id IS NOT NULL
GROUP BY parent_issue_id;
-- SearchIssues: moved to handler (dynamic SQL for multi-word search support).
-- name: MarkIssueFirstExecuted :one
-- Flips first_executed_at from NULL to now() atomically. Returns the row if
-- this was the first time the issue was executed; no rows otherwise. The
-- analytics issue_executed event fires exactly when this returns a row —
-- retries and re-assignments hit the WHERE clause and no-op.
UPDATE issue
SET first_executed_at = now()
WHERE id = $1 AND first_executed_at IS NULL
RETURNING id, workspace_id, creator_type, creator_id, first_executed_at;