highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-23 13:29:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Change base_blob::SetHex() to take std::string_view

Browse Source 
Clarify that hex strings are parsed as little-endian.
This commit is contained in:
Hodlinator
2024-07-23 14:51:36 +02:00
parent 2f5577dc2e
commit 01e314ce0a
3 changed files with 25 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/uint256_tests.cpp
View File

@@ -58,13 +58,8 @@ static std::string ArrayToString(const unsigned char A[], unsigned int width)
return Stream.str();
}
inline uint160 uint160S(const char *str)
{
uint160 rv;
rv.SetHex(str);
return rv;
}
inline uint160 uint160S(const std::string& str)
// Input is treated as little-endian.
inline uint160 uint160S(std::string_view str)
{
uint160 rv;
rv.SetHex(str);
@@ -156,6 +151,10 @@ BOOST_AUTO_TEST_CASE( comparison ) // <= >= < >
BOOST_CHECK_LT(OneS, MaxS);
BOOST_CHECK_LT(R1S, MaxS);
BOOST_CHECK_LT(R2S, MaxS);
// Verify hex strings are little-endian
BOOST_CHECK_LT(uint256S("2000000000000000000000000000000000000000000000000000000000000001"),
uint256S("1000000000000000000000000000000000000000000000000000000000000002"));
}
BOOST_AUTO_TEST_CASE( methods ) // GetHex SetHex begin() end() size() GetLow64 GetSerializeSize, Serialize, Unserialize