RPC help documentation for addnode peerinfo.

Also adds a comment about the netgroup exclusion behavior.
This commit is contained in:
Gregory Maxwell
2016-12-11 20:26:06 +00:00
parent 90f13e1822
commit 032ba3f066
2 changed files with 6 additions and 0 deletions

View File

@@ -1633,6 +1633,11 @@ void CConnman::ThreadOpenConnections()
LOCK(cs_vNodes);
BOOST_FOREACH(CNode* pnode, vNodes) {
if (!pnode->fInbound && !pnode->fAddnode) {
// Netgroups for inbound and addnode peers are not excluded because our goal here
// is to not use multiple of our limited outbound slots on a single netgroup
// but inbound and addnode peers do not use our outbound slots. Inbound peers
// also have the added issue that they're attacker controlled and could be used
// to prevent us from connecting to particular hosts if we used them here.
setConnected.insert(pnode->addr.GetGroup());
nOutbound++;
}