Validate port options

Check `port` options for invalid values (ports are parsed as uint16, so
in practice values >65535 are invalid; port 0 is undefined and therefore
considered invalid too). This allows for an early rejection of faulty
values and an supplying an informative message to the user.

Splits tests in `feature_proxy.py` to cover both invalid `hostname`
and `port` values.

Adds a release-note as previously valid `-port` and `-rpcport` values
can now result in errors.
This commit is contained in:
amadeuszpawlik
2021-05-27 14:07:35 +02:00
committed by Amadeusz Pawlik
parent f8387c4234
commit 04526787b5
5 changed files with 80 additions and 9 deletions

View File

@@ -0,0 +1,4 @@
Updated settings
----------------
- Ports specified in `-port` and `-rpcport` options are now validated at startup. Values that previously worked and were considered valid can now result in errors. (#22087)