highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-29 10:19:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add CONTRIBUTING.md

Browse Source
This commit is contained in:
BtcDrak
2015-09-24 14:28:07 +01:00
parent ef4945f221
commit 06d92d71a2
3 changed files with 118 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
doc/developer-notes.md
View File

@ -1,5 +1,5 @@
Coding
====================
Coding Standards
================
Various coding styles have been used during the history of the codebase,
and the result is not very consistent. However, we're now trying to converge to
@ -171,16 +171,3 @@ Threads
- BitcoinMiner : Generates bitcoins (if wallet is enabled).
- Shutdown : Does an orderly shutdown of everything.
Pull Request Terminology
------------------------
Concept ACK - Agree with the idea and overall direction, but have neither reviewed nor tested the code changes.
utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested them.
Tested ACK - Reviewed the code changes and have verified the functionality or bug fix.
ACK - A loose ACK can be confusing. It's best to avoid them unless it's a documentation/comment only change in which case there is nothing to test/verify; therefore the tested/untested distinction is not there.
NACK - Disagree with the code changes/concept. Should be accompanied by an explanation.