mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-05 02:33:07 +02:00
Merge #16383: rpcwallet: default include_watchonly to true for watchonly wallets
72eaab073btests: functional watch-only wallet tests (William Casarin)72ffbdc579doc: add release note for include_watchonly default changes (William Casarin)003a3c73c0rpcwallet: document include_watchonly default for watchonly wallets (William Casarin)a50d9e6c0brpcwallet: default include_watchonly to true for watchonly wallets (William Casarin) Pull request description: Right now it's a bit annoying to deal with watchonly wallets, many rpc commands have an `include_watchonly` argument that needs to be explicitly set. Wallets created with `createwallet` can have a `disable_private_keys` parameter, for those wallets we already know that they are watchonly, so there's no reason to have to explicitly ask for it for every command. Instead we check this wallet flag when the `include_watchonly` parameter isn't set. ACKs for top commit: achow101: Code review ACK72eaab073bSjors: ACK72eaab073bpromag: ACK72eaab073b, code review only, didn't look closely to the test. kallewoof: ACK72eaab073bfanquake: ACK72eaab073b- I've looked over the changes, they make sense to me. Compiled and ran the tests etc. Tree-SHA512: d3646b55e97f386594d7efc994f0712f3888475c6a5dc7f131ac9f8c49bf5d4677182b88f42b34152abe1ad101ecadd152b4c20e9d3c1267190db36f77ab8bd7
This commit is contained in:
@@ -129,6 +129,8 @@ BASE_SCRIPTS = [
|
||||
'wallet_multiwallet.py --usecli',
|
||||
'wallet_createwallet.py',
|
||||
'wallet_createwallet.py --usecli',
|
||||
'wallet_watchonly.py',
|
||||
'wallet_watchonly.py --usecli',
|
||||
'interface_http.py',
|
||||
'interface_rpc.py',
|
||||
'rpc_psbt.py',
|
||||
|
||||
Reference in New Issue
Block a user