mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-28 15:58:42 +02:00
Merge bitcoin/bitcoin#30415: contrib: fix check-deps.sh to check for weak symbols
3ae35b427fci: run check-deps.sh as part of clang-tidy job (Ryan Ofsky)0aaa1298a0contrib: fix check-deps.sh when libraries do not import symbols (Ryan Ofsky)3c99f5a38acontrib: fix check-deps.sh to check for weak symbols (Ryan Ofsky)86c80e9cf2contrib: make check-deps.sh script work with cmake (Ryan Ofsky) Pull request description: Fix check-deps.sh to check for weak symbols so it can detect when an exported template function like is used from another library. Also update the script to work with cmake and configure it to run as part of CI. Problem was reported by hebasto in https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-2209258843 ACKs for top commit: TheCharlatan: Re-ACK3ae35b427fhebasto: ACK3ae35b427f, I have reviewed the code and it looks OK. Also I've tested it locally. Tree-SHA512: c3b58175450b675e6e848549b81bcfe42930ea9bcd693063867ce3f0ac3999c98cd2c3e961f163ff06641e8288f3a4e81530936a296a83d45d33364f27489521
This commit is contained in:
@@ -14,6 +14,7 @@ export NO_DEPENDS=1
|
||||
export RUN_UNIT_TESTS=false
|
||||
export RUN_FUNCTIONAL_TESTS=false
|
||||
export RUN_FUZZ_TESTS=false
|
||||
export RUN_CHECK_DEPS=true
|
||||
export RUN_TIDY=true
|
||||
export GOAL="install"
|
||||
export BITCOIN_CONFIG="\
|
||||
|
||||
@@ -137,6 +137,10 @@ if [ -n "$USE_VALGRIND" ]; then
|
||||
"${BASE_ROOT_DIR}/ci/test/wrap-valgrind.sh"
|
||||
fi
|
||||
|
||||
if [ "$RUN_CHECK_DEPS" = "true" ]; then
|
||||
"${BASE_ROOT_DIR}/contrib/devtools/check-deps.sh" .
|
||||
fi
|
||||
|
||||
if [ "$RUN_UNIT_TESTS" = "true" ]; then
|
||||
DIR_UNIT_TEST_DATA="${DIR_UNIT_TEST_DATA}" LD_LIBRARY_PATH="${DEPENDS_DIR}/${HOST}/lib" CTEST_OUTPUT_ON_FAILURE=ON ctest "${MAKEJOBS}"
|
||||
fi
|
||||
|
||||
Reference in New Issue
Block a user