mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-04 18:22:57 +02:00
Merge bitcoin/bitcoin#35379: test: Fix feature_dbcrash.py --usecli error
fad585b6e5test: Wait for node exit after crash in verify_utxo_hash (MarcoFalke)faf1475514ci: Exclude feature_dbcrash.py under --v2transport --usecli (MarcoFalke)fac27d702ftest: Fix feature_dbcrash.py --usecli intermittent error (MarcoFalke)fa09de8b68test: [refactor] Simplify submit_block_catch_error (MarcoFalke) Pull request description: This fixes a small intermittent issue that snuck in via commitfa8d4d5c35. Generally, it seems tedious and brittle trying to enumerate all possible exception types on all platforms and all test configs, all possible errno values, etc. So just treat any `Exception` as crash, and confirm it in the test. The test would still fail, if a crash did not happen after an Exception, but the failure may be minimally more tedious to debug. I think this is fine, because failures should be rare and having simpler and more flexible test code is preferable. ---- Also, disable the test for now in CI, because it is quite slow. ACKs for top commit: willcl-ark: ACKfad585b6e5Tree-SHA512: 6ff69a53908b22904780f29def473f8e26c5b608d89420ac76768d06ea3e3394b5d3f4d488100f9d47f943ff5778a555302ccdaebc11fda7c009205b6a6ca05c
This commit is contained in:
@@ -17,5 +17,5 @@ export BITCOIN_CONFIG="\
|
||||
-DREDUCE_EXPORTS=ON \
|
||||
-DCMAKE_BUILD_TYPE=Debug \
|
||||
"
|
||||
export TEST_RUNNER_EXTRA="--v2transport --usecli --extended"
|
||||
export TEST_RUNNER_EXTRA="--v2transport --usecli --extended --exclude feature_dbcrash" # Run extended tests under --usecli and --v2transport, but exclude the very slow dbcrash
|
||||
export BITCOIN_CMD="bitcoin -m" # Used in functional tests
|
||||
|
||||
Reference in New Issue
Block a user