highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-07 14:18:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

wallet: drop stale TODOs

Browse Source
This commit is contained in:
Sjors Provoost
2026-03-25 14:06:19 +01:00
parent 2fe76ed832
commit 1438165b1f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/wallet/external_signer_scriptpubkeyman.cpp
View File

@@ -88,7 +88,6 @@ std::optional<PSBTError> ExternalSignerScriptPubKeyMan::FillPSBT(PartiallySigned
// Already complete if every input is now signed // Already complete if every input is now signed
bool complete = true; bool complete = true;
for (const auto& input : psbt.inputs) { for (const auto& input : psbt.inputs) {
// TODO: for multisig wallets, we should only care if all _our_ inputs are signed
complete &= PSBTInputSigned(input); complete &= PSBTInputSigned(input);
} }
if (complete) return {}; if (complete) return {};
@@ -104,7 +103,7 @@ std::optional<PSBTError> ExternalSignerScriptPubKeyMan::FillPSBT(PartiallySigned
LogWarning("Failed to sign: %s\n", failure_reason); LogWarning("Failed to sign: %s\n", failure_reason);
return PSBTError::EXTERNAL_SIGNER_FAILED; return PSBTError::EXTERNAL_SIGNER_FAILED;
} }
if (finalize) FinalizePSBT(psbt); // This won't work in a multisig setup if (finalize) FinalizePSBT(psbt);
return {}; return {};
} }
} // namespace wallet } // namespace wallet