consensus, refactor: Avoid CScriptCheck::swap in CheckInputScripts

This commit is contained in:
Hennadii Stepanov
2023-03-21 13:03:16 +00:00
parent f4e42a78c7
commit 15209d97c6
2 changed files with 6 additions and 2 deletions

View File

@@ -1815,8 +1815,7 @@ bool CheckInputScripts(const CTransaction& tx, TxValidationState& state,
// Verify signature
CScriptCheck check(txdata.m_spent_outputs[i], tx, i, flags, cacheSigStore, &txdata);
if (pvChecks) {
pvChecks->push_back(CScriptCheck());
check.swap(pvChecks->back());
pvChecks->emplace_back(std::move(check));
} else if (!check()) {
if (flags & STANDARD_NOT_MANDATORY_VERIFY_FLAGS) {
// Check whether the failure was caused by a