highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-28 23:08:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

wallet: update fee rate units, use sat/vB for fee_rate error messages

Browse Source 
and BTC/kvB for feeRate error messages.
This commit is contained in:
Jon Atack
2020-11-08 19:57:35 +01:00
parent 7f9835a05a
commit 173b5b5fe0
9 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/functional/wallet_send.py
View File

@@ -306,11 +306,10 @@ class WalletSendTest(BitcoinTestFramework):
self.test_send(from_wallet=w0, to_wallet=w1, amount=1, conf_target=v, estimate_mode=mode,
expect_error=(-3, "Expected type number for conf_target, got {}".format(k)))
# TODO: The error message should use sat/vB units instead of BTC/kB.
# Test setting explicit fee rate just below the minimum.
self.log.info("Explicit fee rate raises RPC error 'fee rate too low' if fee_rate of 0.99999999 is passed")
self.test_send(from_wallet=w0, to_wallet=w1, amount=1, fee_rate=0.99999999,
expect_error=(-4, "Fee rate (0.00000999 BTC/kB) is lower than the minimum fee rate setting (0.00001000 BTC/kB)"))
expect_error=(-4, "Fee rate (0.999 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)"))
# TODO: Return hex if fee rate is below -maxmempool
# res = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, conf_target=0.1, estimate_mode="sat/b", add_to_wallet=False)