Merge #17762: net: Log to net category for exceptions in ProcessMessages

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-14 09:37:59 +02:00

4bdd68f301 Add missing typeinfo includes (Wladimir J. van der Laan)
4d88c3dcb6 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan)

Pull request description:

  Remove the forest of special exceptions based on string matching, and simply log a short message to the NET logging category when an exception happens during packet processing. It is not good to panick end users with verbose errors (let alone writing to stderr) when any peer can generate them.

ACKs for top commit:
  MarcoFalke:
    re-ACK 4bdd68f301 (only change is adding includes) 🕕
  promag:
    ACK 4bdd68f301, could squash.

Tree-SHA512: a005591a3202b005c75e01dfa54249db3992e2f9eefa8b3d9d435acf66130417716ed926ce4e045179cf43788f1abc7362d999750681a9c80b318373d611c366

This commit is contained in:

Wladimir J. van der Laan

2020-01-02 21:38:26 +01:00

parent 52900a764c 4bdd68f301

commit 190a4051fd

2 changed files with 5 additions and 25 deletions

									
										1

src/util/system.cpp
									
												View File
												
				@@ -64,6 +64,7 @@

				#endif

				#include <thread>

				#include <typeinfo>

				#include <univalue.h>

				// Application startup time (used for uptime calculation)

Merge #17762: net: Log to net category for exceptions in ProcessMessages

1 src/util/system.cpp Unescape Escape View File

1

src/util/system.cpp

View File