highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-13 05:10:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

devtools: Fix verneed section parsing in pixie

Browse Source 
I misunderstood the ELF specification for version symbols (verneed):
The `vn_aux` pointer is relative to the main verneed record, not the
start of the section.

This caused many symbols to not be versioned properly in the return
value of `elf.dyn_symbols`. This was discovered in #21454.

Fix it by correcting the offset computation.
This commit is contained in:
W. J. van der Laan 2021-06-14 20:24:52 +02:00
parent 3a2c84a6b5
commit 19e598bab0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/devtools/pixie.py
View File

@ -217,7 +217,7 @@ def _parse_verneed(section: Section, strings: bytes, eh: ELFHeader) -> Dict[int,
result = {} result = {}
while True: while True:
verneed = Verneed(data, ofs, eh) verneed = Verneed(data, ofs, eh)
aofs = verneed.vn_aux aofs = ofs + verneed.vn_aux
while True: while True:
vernaux = Vernaux(data, aofs, eh, strings) vernaux = Vernaux(data, aofs, eh, strings)
result[vernaux.vna_other] = vernaux.name result[vernaux.vna_other] = vernaux.name