highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 15:19:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

kernel: improve BlockChecked ownership semantics

Browse Source 
Subscribers to the BlockChecked validation interface event may need
access to the block outside of the callback scope. Currently, this
is only possible by copying the block, which makes exposing this
validation interface event publicly either cumbersome or with significant
copy overhead.

By using shared_ptr, we make the shared ownership explicit and allow
users to safely use the block outside of the callback scope.
This commit is contained in:
stickies-v
2025-07-28 13:57:52 +01:00
parent 9ba1fff29e
commit 1d9f1cb4bd
8 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/test/validationinterface_tests.cpp
View File

@@ -12,11 +12,12 @@
#include <validationinterface.h>
#include <atomic>
#include <memory>
BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, ChainTestingSetup)
struct TestSubscriberNoop final : public CValidationInterface {
void BlockChecked(const CBlock&, const BlockValidationState&) override {}
void BlockChecked(const std::shared_ptr<const CBlock>&, const BlockValidationState&) override {}
};
BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)
@@ -25,10 +26,9 @@ BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)
// Start thread to generate notifications
std::thread gen{[&] {
const CBlock block_dummy;
BlockValidationState state_dummy;
while (generate) {
m_node.validation_signals->BlockChecked(block_dummy, state_dummy);
m_node.validation_signals->BlockChecked(std::make_shared<const CBlock>(), state_dummy);
}
}};
@@ -60,15 +60,14 @@ public:
{
if (m_on_destroy) m_on_destroy();
}
void BlockChecked(const CBlock& block, const BlockValidationState& state) override
void BlockChecked(const std::shared_ptr<const CBlock>& block, const BlockValidationState& state) override
{
if (m_on_call) m_on_call();
}
void Call()
{
CBlock block;
BlockValidationState state;
m_signals.BlockChecked(block, state);
m_signals.BlockChecked(std::make_shared<const CBlock>(), state);
}
std::function<void()> m_on_call;
std::function<void()> m_on_destroy;