highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-05 18:52:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: rename CBlockHeader .hash -> .hash_hex for consistency

Browse Source 
Note that we unfortunately can't use a scripted diff here, as the
`.hash` symbol is also used for other instances (e.g. CInv).
This commit is contained in:
Sebastian Falbesoner
2025-06-12 15:13:11 +02:00
parent 23be0ec2f0
commit 2118301d77
22 changed files with 84 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/functional/rpc_blockchain.py
View File

@@ -480,7 +480,7 @@ class BlockchainTest(BitcoinTestFramework):
assert_is_hex_string(header_hex)
header = from_hex(CBlockHeader(), header_hex)
assert_equal(header.hash, besthash)
assert_equal(header.hash_hex, besthash)
assert 'previousblockhash' not in node.getblockheader(node.getblockhash(0))
assert 'nextblockhash' not in node.getblockheader(node.getbestblockhash())
@@ -623,7 +623,7 @@ class BlockchainTest(BitcoinTestFramework):
b1 = solve_and_send_block(int(fork_hash, 16), fork_height+1, fork_block['time'] + 1)
b2 = solve_and_send_block(b1.hash_int, fork_height+2, b1.nTime + 1)
node.invalidateblock(b2.hash)
node.invalidateblock(b2.hash_hex)
def assert_waitforheight(height, timeout=2):
assert_equal(
@@ -729,7 +729,7 @@ class BlockchainTest(BitcoinTestFramework):
block = create_block(int(blockhash, 16), create_coinbase(current_height + 1, nValue=100), block_time)
block.solve()
node.submitheader(block.serialize().hex())
assert_raises_rpc_error(-1, "Block not available (not fully downloaded)", lambda: node.getblock(block.hash))
assert_raises_rpc_error(-1, "Block not available (not fully downloaded)", lambda: node.getblock(block.hash_hex))
self.log.info("Test getblock when block data is available but undo data isn't")
# Submits a block building on the header-only block, so it can't be connected and has no undo data
@@ -738,10 +738,10 @@ class BlockchainTest(BitcoinTestFramework):
block_noundo.solve()
node.submitblock(block_noundo.serialize().hex())
assert_fee_not_in_block(block_noundo.hash, 2)
assert_fee_not_in_block(block_noundo.hash, 3)
assert_vin_does_not_contain_prevout(block_noundo.hash, 2)
assert_vin_does_not_contain_prevout(block_noundo.hash, 3)
assert_fee_not_in_block(block_noundo.hash_hex, 2)
assert_fee_not_in_block(block_noundo.hash_hex, 3)
assert_vin_does_not_contain_prevout(block_noundo.hash_hex, 2)
assert_vin_does_not_contain_prevout(block_noundo.hash_hex, 3)
self.log.info("Test getblock when block is missing")
move_block_file('blk00000.dat', 'blk00000.dat.bak')