highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-31 10:10:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

net: Combine two loops into one, and update comments

Browse Source
This commit is contained in:
Hennadii Stepanov 2021-04-12 14:54:58 +03:00
parent a3d090d110
commit 229ac1892d
No known key found for this signature in database
GPG Key ID: 410108112E7EA81F
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/net.cpp
View File

@ -2635,20 +2635,20 @@ void CConnman::StopNodes()
} }
} }
// Close sockets // Delete peer connections.
std::vector<CNode*> nodes; std::vector<CNode*> nodes;
WITH_LOCK(cs_vNodes, nodes.swap(vNodes)); WITH_LOCK(cs_vNodes, nodes.swap(vNodes));
for (CNode* pnode : nodes) for (CNode* pnode : nodes) {
pnode->CloseSocketDisconnect(); pnode->CloseSocketDisconnect();
DeleteNode(pnode);
}
// Close listening sockets.
for (ListenSocket& hListenSocket : vhListenSocket) for (ListenSocket& hListenSocket : vhListenSocket)
if (hListenSocket.socket != INVALID_SOCKET) if (hListenSocket.socket != INVALID_SOCKET)
if (!CloseSocket(hListenSocket.socket)) if (!CloseSocket(hListenSocket.socket))
LogPrintf("CloseSocket(hListenSocket) failed with error %s\n", NetworkErrorString(WSAGetLastError())); LogPrintf("CloseSocket(hListenSocket) failed with error %s\n", NetworkErrorString(WSAGetLastError()));
// clean up some globals (to help leak detection)
for (CNode* pnode : nodes) {
DeleteNode(pnode);
}
for (CNode* pnode : vNodesDisconnected) { for (CNode* pnode : vNodesDisconnected) {
DeleteNode(pnode); DeleteNode(pnode);
} }