highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-10 17:02:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#25027: test: Remove boost::split from getarg_tests.cpp

Browse Source 
fafa7276126d21d7e2f723673b64382e16a902d9 test: Remove boost::split from getarg_tests.cpp (MacroFake)

Pull request description:

  Only single spaces are used, so no need for boost.

  Can be tested with:

  ```diff
  diff --git a/src/test/getarg_tests.cpp b/src/test/getarg_tests.cpp
  index c877105fe7..a834830490 100644
  --- a/src/test/getarg_tests.cpp
  +++ b/src/test/getarg_tests.cpp
  @@ -21,8 +21,11 @@ BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
   void ResetArgs(ArgsManager& local_args, const std::string& strArg)
   {
       std::vector<std::string> vecArg;
  -    if (strArg.size())
  +    if (strArg.size()) {
           boost::split(vecArg, strArg, IsSpace, boost::token_compress_on);
  +        auto vecArg2{SplitString(strArg, ' ')};
  +        assert(vecArg2 == vecArg);
  +    }

       // Insert dummy executable name:
       vecArg.insert(vecArg.begin(), "testbitcoin");

ACKs for top commit:
  fanquake:
    utACK fafa7276126d21d7e2f723673b64382e16a902d9 - After this, the last usage of `<boost/algorithm/string.hpp>` is in `httprpc.cpp`.

Tree-SHA512: 038af095cfb5240216305919cdeeb12d8e3ff0424520b99785bff5353a47dfcacdc049b927d7316b13e17a3c19b5f7549c9db7c4b5f2fa78ff1816515ca28d9d
This commit is contained in:
fanquake 2022-04-30 09:59:40 +01:00
commit 23daa86ec1
No known key found for this signature in database
GPG Key ID: 2EEB9F5CC09526C1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/getarg_tests.cpp
View File

@ -13,7 +13,6 @@
#include <utility> #include <utility>
#include <vector> #include <vector>
#include <boost/algorithm/string.hpp>
#include <boost/test/unit_test.hpp> #include <boost/test/unit_test.hpp>
BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup) BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
@ -21,8 +20,9 @@ BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
void ResetArgs(ArgsManager& local_args, const std::string& strArg) void ResetArgs(ArgsManager& local_args, const std::string& strArg)
{ {
std::vector<std::string> vecArg; std::vector<std::string> vecArg;
if (strArg.size()) if (strArg.size()) {
boost::split(vecArg, strArg, IsSpace, boost::token_compress_on); vecArg = SplitString(strArg, ' ');
}
// Insert dummy executable name: // Insert dummy executable name:
vecArg.insert(vecArg.begin(), "testbitcoin"); vecArg.insert(vecArg.begin(), "testbitcoin");