Document validationinterace callback blocking deadlock potential.

This commit is contained in:
Matt Corallo
2018-05-11 16:56:19 -04:00
parent a589f536b5
commit 25bc9615b7
2 changed files with 18 additions and 4 deletions

View File

@@ -2704,6 +2704,9 @@ bool CChainState::ActivateBestChain(CValidationState &state, const CChainParams&
// Block until the validation queue drains. This should largely
// never happen in normal operation, however may happen during
// reindex, causing memory blowup if we run too far ahead.
// Note that if a validationinterface callback ends up calling
// ActivateBestChain this may lead to a deadlock! We should
// probably have a DEBUG_LOCKORDER test for this in the future.
SyncWithValidationInterfaceQueue();
}