highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-04 02:02:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use c++20 std::views::reverse instead of reverse_iterator.h

Browse Source 
Use std::ranges::views::reverse instead of the implementation in
reverse_iterator.h, and remove it as it is no longer used.
This commit is contained in:
stickies-v
2023-10-19 12:46:32 +01:00
parent 949b673472
commit 2925bd537c
9 changed files with 22 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/fuzz/prevector.cpp
View File

@@ -2,16 +2,14 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <prevector.h>
#include <serialize.h>
#include <streams.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
#include <prevector.h>
#include <ranges>
#include <vector>
#include <reverse_iterator.h>
#include <serialize.h>
#include <streams.h>
namespace {
template <unsigned int N, typename T>
@@ -47,7 +45,7 @@ public:
assert(v == real_vector[pos]);
++pos;
}
for (const T& v : reverse_iterate(pre_vector)) {
for (const T& v : pre_vector | std::views::reverse) {
--pos;
assert(v == real_vector[pos]);
}
@@ -55,7 +53,7 @@ public:
assert(v == real_vector[pos]);
++pos;
}
for (const T& v : reverse_iterate(const_pre_vector)) {
for (const T& v : const_pre_vector | std::views::reverse) {
--pos;
assert(v == real_vector[pos]);
}

15
src/test/prevector_tests.cpp
View File

@@ -3,17 +3,16 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <prevector.h>
#include <vector>
#include <reverse_iterator.h>
#include <serialize.h>
#include <streams.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <boost/test/unit_test.hpp>
#include <ranges>
#include <vector>
BOOST_FIXTURE_TEST_SUITE(prevector_tests, TestingSetup)
template<unsigned int N, typename T>
@@ -58,14 +57,14 @@ class prevector_tester {
for (const T& v : pre_vector) {
local_check(v == real_vector[pos++]);
}
for (const T& v : reverse_iterate(pre_vector)) {
local_check(v == real_vector[--pos]);
for (const T& v : pre_vector | std::views::reverse) {
local_check(v == real_vector[--pos]);
}
for (const T& v : const_pre_vector) {
local_check(v == real_vector[pos++]);
}
for (const T& v : reverse_iterate(const_pre_vector)) {
local_check(v == real_vector[--pos]);
for (const T& v : const_pre_vector | std::views::reverse) {
local_check(v == real_vector[--pos]);
}
DataStream ss1{};
DataStream ss2{};