highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-10 20:53:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

mapport: rename 'use_pcp' to 'enable'

Browse Source 
There is only a single protocol now, caller should just be concerned about whether to enable port mapping or not.
This commit is contained in:
Antoine Poinsot
2024-10-29 11:58:51 -04:00
parent c4e82b854c
commit 2a6536ceda
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/interfaces/node.h
View File

@@ -121,7 +121,7 @@ public:
virtual void resetSettings() = 0; virtual void resetSettings() = 0;
//! Map port. //! Map port.
virtual void mapPort(bool use_pcp) = 0; virtual void mapPort(bool enable) = 0;
//! Get proxy. //! Get proxy.
virtual bool getProxy(Network net, Proxy& proxy_info) = 0; virtual bool getProxy(Network net, Proxy& proxy_info) = 0;

4
src/mapport.cpp
View File

@@ -166,9 +166,9 @@ static void MapPortProtoSetEnabled(bool enabled)
g_mapport_enabled = enabled; g_mapport_enabled = enabled;
} }
void StartMapPort(bool use_pcp) void StartMapPort(bool enable)
{ {
MapPortProtoSetEnabled(use_pcp); MapPortProtoSetEnabled(enable);
DispatchMapPort(); DispatchMapPort();
} }

2
src/mapport.h
View File

@@ -7,7 +7,7 @@
static constexpr bool DEFAULT_NATPMP = false; static constexpr bool DEFAULT_NATPMP = false;
void StartMapPort(bool use_pcp); void StartMapPort(bool enable);
void InterruptMapPort(); void InterruptMapPort();
void StopMapPort(); void StopMapPort();

2
src/node/interfaces.cpp
View File

@@ -187,7 +187,7 @@ public:
}); });
args().WriteSettingsFile(); args().WriteSettingsFile();
} }
void mapPort(bool use_pcp) override { StartMapPort(use_pcp); } void mapPort(bool enable) override { StartMapPort(enable); }
bool getProxy(Network net, Proxy& proxy_info) override { return GetProxy(net, proxy_info); } bool getProxy(Network net, Proxy& proxy_info) override { return GetProxy(net, proxy_info); }
size_t getNodeCount(ConnectionDirection flags) override size_t getNodeCount(ConnectionDirection flags) override
{ {