highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-11 14:38:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: Drop excessive locking in CAddrManTest::SimConnFail

Browse Source 
The unit test is single threaded, so there's no need to hold the mutex
between Good() and Attempt().

This change avoids recursive locking in the CAddrMan::Attempt function.

Co-authored-by: John Newbery <john@johnnewbery.com>
This commit is contained in:
Hennadii Stepanov
2021-05-23 16:27:14 +03:00
parent 5c4f0c4d46
commit 2da95545ea
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/addrman_tests.cpp
View File

@@ -74,9 +74,9 @@ public:
// Simulates connection failure so that we can test eviction of offline nodes // Simulates connection failure so that we can test eviction of offline nodes
void SimConnFail(const CService& addr) void SimConnFail(const CService& addr)
{ {
LOCK(cs);
int64_t nLastSuccess = 1; int64_t nLastSuccess = 1;
Good_(addr, true, nLastSuccess); // Set last good connection in the deep past. // Set last good connection in the deep past.
Good(addr, true, nLastSuccess);
bool count_failure = false; bool count_failure = false;
int64_t nLastTry = GetAdjustedTime()-61; int64_t nLastTry = GetAdjustedTime()-61;