highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-05 18:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

fuzz: use std::optional for sep_pos variable

Browse Source 
Co-authored-by: MarcoFalke <falke.marco@gmail.com>
This commit is contained in:
Harris
2020-05-09 11:09:52 +02:00
parent b55866969e
commit 420fa0770f
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/fuzz/asmap_direct.cpp
View File

@@ -6,6 +6,7 @@
#include <test/fuzz/fuzz.h>
#include <cstdint>
#include <optional>
#include <vector>
#include <assert.h>
@@ -13,20 +14,19 @@
void test_one_input(const std::vector<uint8_t>& buffer)
{
// Encoding: [asmap using 1 bit / byte] 0xFF [addr using 1 bit / byte]
bool have_sep = false;
size_t sep_pos;
std::optional<size_t> sep_pos_opt;
for (size_t pos = 0; pos < buffer.size(); ++pos) {
uint8_t x = buffer[pos];
if ((x & 0xFE) == 0) continue;
if (x == 0xFF) {
if (have_sep) return;
have_sep = true;
sep_pos = pos;
if (sep_pos_opt) return;
sep_pos_opt = pos;
} else {
return;
}
}
if (!have_sep) return; // Needs exactly 1 separator
if (!sep_pos_opt) return; // Needs exactly 1 separator
const size_t sep_pos{sep_pos_opt.value()};
if (buffer.size() - sep_pos - 1 > 128) return; // At most 128 bits in IP address
// Checks on asmap