highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-29 18:20:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

wallet: provide valid values if invalid estimate mode passed

Browse Source 
Co-authored-by: Murch <murch@murch.one>
This commit is contained in:
Jon Atack
2020-11-10 12:29:01 +01:00
parent 6da3afbaee
commit 449b730579
10 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/functional/rpc_psbt.py
View File

@ -231,7 +231,7 @@ class PSBTTest(BitcoinTestFramework):
assert_raises_rpc_error(-3, "Expected type string for estimate_mode, got {}".format(k),
self.nodes[1].walletcreatefundedpsbt, inputs, outputs, 0, {"estimate_mode": v, "conf_target": 0.1, "add_inputs": True})
for mode in ["", "foo", Decimal("3.141592")]:
assert_raises_rpc_error(-8, "Invalid estimate_mode parameter",
assert_raises_rpc_error(-8, 'Invalid estimate_mode parameter, must be one of: "unset", "economical", "conservative"',
self.nodes[1].walletcreatefundedpsbt, inputs, outputs, 0, {"estimate_mode": mode, "conf_target": 0.1, "add_inputs": True})
self.log.info("- raises RPC error with invalid conf_target settings")