highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-18 12:53:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#23881: doc: Remove TODO from block fuzz test

Browse Source 
fa5d0b6ecda384b591fff42b4072fa7d02525975 doc: Remove TODO from block fuzz test (MarcoFalke)

Pull request description:

  I don't see a reason to fix the TODO, as all call sites assume at least one tx in `vtx`. So remove it.

ACKs for top commit:
  fanquake:
    ACK fa5d0b6ecda384b591fff42b4072fa7d02525975

Tree-SHA512: 8fe03a5bdebf4d6dad00f410a1dc6449c485a4d61afb79ebcaa221489cde2a465fea981742fde130238ebed6d2f1f032aa4976726ee07b23fe7fb745b2728d46
This commit is contained in:
fanquake 2021-12-28 20:21:23 +08:00
commit 45249e70d9
No known key found for this signature in database
GPG Key ID: 2EEB9F5CC09526C1
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/fuzz/block.cpp
View File

@ -58,8 +58,6 @@ FUZZ_TARGET_INIT(block, initialize_block)
(void)block.ToString(); (void)block.ToString();
(void)BlockMerkleRoot(block); (void)BlockMerkleRoot(block);
if (!block.vtx.empty()) { if (!block.vtx.empty()) {
// TODO: Avoid array index out of bounds error in BlockWitnessMerkleRoot
// when block.vtx.empty().
(void)BlockWitnessMerkleRoot(block); (void)BlockWitnessMerkleRoot(block);
} }
(void)GetBlockWeight(block); (void)GetBlockWeight(block);