util: change GetWarnings parameter to bool

GetWarnings() changes the format of the output warning string based on a
passed-in string argument that can be set to "gui" or "statusbar".
Change the argument to a bool:

- there are only two types of behaviour, so a bool is a more natural
argument type
- changing the name to 'verbose' does not set any expectations for the
how the calling code will use the returned string (currently,
'statusbar' is used for RPC warnings, not a status bar)
- removes some error-handling code for when the passed-in string is not
one of the two strings expected.
This commit is contained in:
John Newbery
2019-12-15 12:44:09 -03:00
parent 869b6314fd
commit 492c6dc1e7
7 changed files with 23 additions and 27 deletions

View File

@@ -522,7 +522,7 @@ static UniValue getnetworkinfo(const JSONRPCRequest& request)
}
}
obj.pushKV("localaddresses", localAddresses);
obj.pushKV("warnings", GetWarnings("statusbar"));
obj.pushKV("warnings", GetWarnings(false));
return obj;
}