highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-04 20:51:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace use of boost::trim_right with locale-independent TrimString

Browse Source 
Note the only use of readStdin is fed to DecodeHexTx, which fails in
IsHex on non-hex characters as recorded in p_util_hexdigit.
This commit is contained in:
Ben Woosley
2020-02-12 12:33:37 -05:00
committed by fanquake
parent 93551862a1
commit 4bf18b089e
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bitcoin-tx.cpp
View File

@ -772,9 +772,7 @@ static std::string readStdin()
if (ferror(stdin)) if (ferror(stdin))
throw std::runtime_error("error reading stdin"); throw std::runtime_error("error reading stdin");
boost::algorithm::trim_right(ret); return TrimString(ret);
return ret;
} }
static int CommandLineRawTx(int argc, char* argv[]) static int CommandLineRawTx(int argc, char* argv[])

1
test/lint/lint-locale-dependence.sh
View File

@ -39,7 +39,6 @@ export LC_ALL=C
KNOWN_VIOLATIONS=( KNOWN_VIOLATIONS=(
"src/bitcoin-tx.cpp.*stoul" "src/bitcoin-tx.cpp.*stoul"
"src/bitcoin-tx.cpp.*trim_right"
"src/dbwrapper.cpp.*stoul" "src/dbwrapper.cpp.*stoul"
"src/dbwrapper.cpp:.*vsnprintf" "src/dbwrapper.cpp:.*vsnprintf"
"src/node/blockstorage.cpp:.*atoi" "src/node/blockstorage.cpp:.*atoi"