mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-01 00:34:01 +02:00
net: Prevent node from binding to the same CService
Currently, if the user inadvertently starts the node with duplicate bind options, such as `-bind=0.0.0.0 -bind=0.0.0.0`, it will cause a fatal error with the misleading message "Bitcoin Core is probably already running". This commit adds early validation to detect duplicate bindings across all binding configurations (-bind, -whitebind, and onion bindings) before attempting to bind. When duplicates are detected, the node terminates with a clear, specific error message: "Duplicate binding configuration for address <addr>. Please check your -bind, -bind=...=onion and -whitebind settings." The validation catches duplicates both within the same option type (e.g., `-bind=X -bind=X`) and across different types (e.g., `-bind=X -whitebind=Y@X`), helping users identify and fix configuration mistakes.
This commit is contained in:
@@ -3,10 +3,12 @@
|
||||
# Distributed under the MIT software license, see the accompanying
|
||||
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
"""
|
||||
Test starting bitcoind with -bind and/or -bind=...=onion and confirm
|
||||
that bind happens on the expected ports.
|
||||
Test starting bitcoind with -bind and/or -bind=...=onion, confirm that
|
||||
it binds to the expected ports, and verify that duplicate or conflicting
|
||||
-bind/-whitebind configurations are rejected with a descriptive error.
|
||||
"""
|
||||
|
||||
from itertools import combinations_with_replacement
|
||||
from test_framework.netutil import (
|
||||
addr_to_hex,
|
||||
get_bind_addrs,
|
||||
@@ -14,13 +16,13 @@ from test_framework.netutil import (
|
||||
from test_framework.test_framework import (
|
||||
BitcoinTestFramework,
|
||||
)
|
||||
from test_framework.test_node import ErrorMatch
|
||||
from test_framework.util import (
|
||||
assert_equal,
|
||||
p2p_port,
|
||||
rpc_port,
|
||||
)
|
||||
|
||||
|
||||
class BindExtraTest(BitcoinTestFramework):
|
||||
def set_test_params(self):
|
||||
self.setup_clean_chain = True
|
||||
@@ -87,5 +89,14 @@ class BindExtraTest(BitcoinTestFramework):
|
||||
binds = set(filter(lambda e: e[1] != rpc_port(i), binds))
|
||||
assert_equal(binds, set(expected_services))
|
||||
|
||||
self.stop_node(0)
|
||||
|
||||
addr = "127.0.0.1:11012"
|
||||
for opt1, opt2 in combinations_with_replacement([f"-bind={addr}", f"-bind={addr}=onion", f"-whitebind=noban@{addr}"], 2):
|
||||
self.nodes[0].assert_start_raises_init_error(
|
||||
[opt1, opt2],
|
||||
"Error: Duplicate binding configuration",
|
||||
match=ErrorMatch.PARTIAL_REGEX)
|
||||
|
||||
if __name__ == '__main__':
|
||||
BindExtraTest(__file__).main()
|
||||
|
||||
Reference in New Issue
Block a user