highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-11 13:50:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Add test for IPC serialization bug

Browse Source 
Add regression test for serialization bug in IPC mining code that is not
currently being called anywhere reported:

https://github.com/Sjors/bitcoin/issues/71
https://github.com/chaincodelabs/libmultiprocess/issues/122
This commit is contained in:
Ryan Ofsky 2025-01-24 19:01:49 -05:00
parent 2221c8814d
commit 4e0aa1835b
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/ipc_test.capnp
View File

@ -20,4 +20,5 @@ interface FooInterface $Proxy.wrap("FooImplementation") {
passTransaction @3 (arg :Data) -> (result :Data);
passVectorChar @4 (arg :Data) -> (result :Data);
passBlockState @5 (arg :Mining.BlockValidationState) -> (result :Mining.BlockValidationState);
passScript @6 (arg :Data) -> (result :Data);
}

4
src/test/ipc_test.cpp
View File

@ -121,6 +121,10 @@ void IpcPipeTest()
BOOST_CHECK_EQUAL(bs3.GetRejectReason(), bs4.GetRejectReason());
BOOST_CHECK_EQUAL(bs3.GetDebugMessage(), bs4.GetDebugMessage());
auto script1{CScript() << OP_11};
auto script2{foo->passScript(script1)};
BOOST_CHECK_EQUAL(HexStr(script1), HexStr(script2));
// Test cleanup: disconnect pipe and join thread
disconnect_client();
thread.join();

2
src/test/ipc_test.h
View File

@ -6,6 +6,7 @@
#define BITCOIN_TEST_IPC_TEST_H
#include <primitives/transaction.h>
#include <script/script.h>
#include <univalue.h>
#include <util/fs.h>
#include <validation.h>
@ -19,6 +20,7 @@ public:
CTransactionRef passTransaction(CTransactionRef t) { return t; }
std::vector<char> passVectorChar(std::vector<char> v) { return v; }
BlockValidationState passBlockState(BlockValidationState s) { return s; }
CScript passScript(CScript s) { return s; }
};
void IpcPipeTest();