refactor: inline constant return value of CDBWrapper::WriteBatch

`WriteBatch` can only ever return `true` - its errors are handled by throwing a `throw dbwrapper_error` instead.
The boolean return value is quite confusing, especially since it's symmetric with `CDBWrapper::Read`, which catches the exceptions and returns a boolean instead.
We're removing the constant return value and inlining `true` for its usages.
This commit is contained in:
Lőrinc
2025-07-22 12:18:54 -07:00
parent 9b1a7c3e8d
commit 50b63a5698
9 changed files with 16 additions and 13 deletions

View File

@@ -234,7 +234,8 @@ public:
{
CDBBatch batch(*this);
batch.Write(key, value);
return WriteBatch(batch, fSync);
WriteBatch(batch, fSync);
return true;
}
//! @returns filesystem path to the on-disk data.
@@ -259,10 +260,11 @@ public:
{
CDBBatch batch(*this);
batch.Erase(key);
return WriteBatch(batch, fSync);
WriteBatch(batch, fSync);
return true;
}
bool WriteBatch(CDBBatch& batch, bool fSync = false);
void WriteBatch(CDBBatch& batch, bool fSync = false);
// Get an estimate of LevelDB memory usage (in bytes).
size_t DynamicMemoryUsage() const;