refactor: inline constant return value of CDBWrapper::WriteBatch

`WriteBatch` can only ever return `true` - its errors are handled by throwing a `throw dbwrapper_error` instead.
The boolean return value is quite confusing, especially since it's symmetric with `CDBWrapper::Read`, which catches the exceptions and returns a boolean instead.
We're removing the constant return value and inlining `true` for its usages.
This commit is contained in:
Lőrinc
2025-07-22 12:18:54 -07:00
parent 9b1a7c3e8d
commit 50b63a5698
9 changed files with 16 additions and 13 deletions

View File

@@ -263,7 +263,7 @@ bool CoinStatsIndex::CustomRemove(const interfaces::BlockInfo& block)
return false;
}
if (!m_db->WriteBatch(batch)) return false;
m_db->WriteBatch(batch);
if (!ReverseBlock(block)) {
return false; // failure cause logged internally