highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-09-01 17:26:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: re-enable UBSan implicit-sign-change in serialize.h

Browse Source 
Made every signed/unsigned conversion in the serialization helpers explicit so the UBSan `implicit-sign-change` check passes and the `serialize.h` suppression can be dropped.

For consistency, a few other simple changes were also applied to the serialization helpers:
* remove redundant `inline` on function templates;
* unify formatting to make the differences between similar methods obvious.
This commit is contained in:
Lőrinc
2025-04-17 16:02:26 +02:00
parent 5827e93507
commit 516f0689b5
2 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/sanitizer_suppressions/ubsan
View File

@@ -65,7 +65,6 @@ implicit-integer-sign-change:TxConfirmStats::removeTx
implicit-integer-sign-change:prevector.h
implicit-integer-sign-change:verify_flags
implicit-integer-sign-change:EvalScript
implicit-integer-sign-change:serialize.h
implicit-signed-integer-truncation:crypto/
implicit-unsigned-integer-truncation:crypto/
shift-base:arith_uint256.cpp