highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-15 10:05:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge #15629: init: Throw error when network specific config is ignored

Browse Source 
fae38c3dc6 doc: Fix all typos reported by codespell (MarcoFalke)
fa9058f0ed doc: Add release notes for 15629 (MarcoFalke)
fa4a922d78 qa: Add test for missing testnet section in conf file (MarcoFalke)
dddd6f0f58 init: Throw error when network specific config is ignored (MarcoFalke)

Pull request description:

  This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error.

  Issues:
  *  bitcoin client 0.17.0 ignores wallet's name (file) #14523
  *  Can't set custom rpcport on testnet #13777
  * ...

ACKs for commit fae38c:

Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530
This commit is contained in:
MarcoFalke
2019-04-09 21:13:58 -04:00
parent 93de9abe6d fae38c3dc6
commit 5392aee64f
6 changed files with 26 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/functional/test_framework/test_node.py
View File

@@ -369,7 +369,7 @@ class TestNode():
stderr=subprocess.DEVNULL, stdout=subprocess.DEVNULL) == 0
if not sys.platform.startswith('linux'):
self.log.warning("Can't profile with perf; only availabe on Linux platforms")
self.log.warning("Can't profile with perf; only available on Linux platforms")
return None
if not test_success('which perf'):