highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-17 13:22:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge 06b3ad2bc93b49ab8e9d330a5dc139112175c132 into 5f4422d68dc3530c353af1f87499de1c864b60ad

Browse Source
This commit is contained in:
Naiyoma 2025-03-17 09:50:15 +07:00 committed by GitHub
commit 542f01fb9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 32 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
test/functional/rpc_whitelist.py
View File

@ -26,7 +26,7 @@ def rpccall(node, user, method):
def get_permissions(whitelist): def get_permissions(whitelist):
return [perm for perm in whitelist.replace(" ", "").split(",") if perm] return [perm for perm in whitelist.split(",") if perm]
class RPCWhitelistTest(BitcoinTestFramework): class RPCWhitelistTest(BitcoinTestFramework):
@ -56,7 +56,7 @@ class RPCWhitelistTest(BitcoinTestFramework):
# Testing the same permission twice # Testing the same permission twice
["strangedude5", "d12c6e962d47a454f962eb41225e6ec8$2dd39635b155536d3c1a2e95d05feff87d5ba55f2d5ff975e6e997a836b717c9", ":getblockcount,getblockcount", "s7R4nG3R7H1nGZ"], ["strangedude5", "d12c6e962d47a454f962eb41225e6ec8$2dd39635b155536d3c1a2e95d05feff87d5ba55f2d5ff975e6e997a836b717c9", ":getblockcount,getblockcount", "s7R4nG3R7H1nGZ"],
# Test non-whitelisted user # Test non-whitelisted user
["strangedude6", "ab02e4fb22ef4ab004cca217a49ee8d2$90dd09b08edd12d552d9d8a5ada838dcef2ac587789fa7e9c47f5990e80cdf93", None, "password123"] ["strangedude6", "67e5583538958883291f6917883eca64$8a866953ef9c5b7d078a62c64754a4eb74f47c2c17821eb4237021d7ef44f991", None, "N4SziYbHmhC1"]
] ]
# These commands shouldn't be allowed for any user to test failures # These commands shouldn't be allowed for any user to test failures
self.never_allowed = ["getnetworkinfo"] self.never_allowed = ["getnetworkinfo"]
@ -74,7 +74,8 @@ class RPCWhitelistTest(BitcoinTestFramework):
for user in self.users: for user in self.users:
for permission in self.never_allowed: for permission in self.never_allowed:
self.log.info("[" + user[0] + "]: Testing a non permitted permission (" + permission + ")") self.log.info(f"[{user[0]}]: Testing a non permitted permission ({permission})")
assert_equal(403, rpccall(self.nodes[0], user, permission).status) assert_equal(403, rpccall(self.nodes[0], user, permission).status)
# Now test the strange users # Now test the strange users
for permission in self.never_allowed: for permission in self.never_allowed:
@ -91,7 +92,7 @@ class RPCWhitelistTest(BitcoinTestFramework):
assert_equal(200, rpccall(self.nodes[0], self.strange_users[4], "getblockcount").status) assert_equal(200, rpccall(self.nodes[0], self.strange_users[4], "getblockcount").status)
self.test_users_permissions() self.test_users_permissions()
self.test_rpcwhitelistdefault_0_no_permissions() self.test_rpcwhitelistdefault_permissions(0, 200)
# Replace file configurations # Replace file configurations
self.nodes[0].replace_in_config([("rpcwhitelistdefault=0", "rpcwhitelistdefault=1")]) self.nodes[0].replace_in_config([("rpcwhitelistdefault=0", "rpcwhitelistdefault=1")])
@ -101,7 +102,9 @@ class RPCWhitelistTest(BitcoinTestFramework):
# Test rpcwhitelistdefault=1 # Test rpcwhitelistdefault=1
self.test_users_permissions() self.test_users_permissions()
self.test_rpcwhitelistdefault_1_no_permissions() self.test_rpcwhitelistdefault_permissions(1, 403)
self.test_rpcwhitelistdefault_unset()
def test_users_permissions(self): def test_users_permissions(self):
""" """
@ -113,32 +116,41 @@ class RPCWhitelistTest(BitcoinTestFramework):
for user in self.users: for user in self.users:
permissions = get_permissions(user[2]) permissions = get_permissions(user[2])
for permission in permissions: for permission in permissions:
self.log.info("[" + user[0] + "]: Testing whitelisted user permission (" + permission + ")") self.log.info(f"[{user[0]}]: Testing whitelisted user permission ({permission})")
assert_equal(200, rpccall(self.nodes[0], user, permission).status) assert_equal(200, rpccall(self.nodes[0], user, permission).status)
self.log.info("[" + user[0] + "]: Testing non-permitted permission: getblockchaininfo") self.log.info(f"[{user[0]}]: Testing non-permitted permission: getblockchaininfo")
assert_equal(403, rpccall(self.nodes[0], user, "getblockchaininfo").status) assert_equal(403, rpccall(self.nodes[0], user, "getblockchaininfo").status)
def test_rpcwhitelistdefault_0_no_permissions(self): def test_rpcwhitelistdefault_permissions(self, default_value, expected_status):
""" """
* rpcwhitelistdefault=0 * rpcwhitelistdefault={default_value}
* No Permissions defined * No Permissions defined
Expected result: * strangedude6 (not whitelisted) can access any method Expected result: strangedude6 (not whitelisted) access is determined by default_value
When default_value=0: expects 403 (forbidden)
When default_value=1: expects 200 (allowed)
""" """
unrestricted_user = self.strange_users[6] user = self.strange_users[6] # strangedude6
for permission in ["getbestblockhash", "getblockchaininfo"]: for permission in ["getbestblockhash", "getblockchaininfo"]:
self.log.info("[" + unrestricted_user[0] + "]: Testing unrestricted user permission (" + permission + ")") self.log.info(f"[{user[0]}]: Testing rpcwhitelistdefault={default_value} no specified permission ({permission})")
assert_equal(200, rpccall(self.nodes[0], unrestricted_user, permission).status) assert_equal(expected_status, rpccall(self.nodes[0], user, permission).status)
def test_rpcwhitelistdefault_1_no_permissions(self): def test_rpcwhitelistdefault_unset(self):
""" """
* rpcwhitelistdefault=1 * rpcwhitelistdefault is unset
* No Permissions defined Expected result:
Expected result: * strangedude6 (not whitelisted) can not access any method - Whitelisted users can only access their whitelisted methods
- Non-whitelisted users cannot access any methods
""" """
self.nodes[0].replace_in_config([("rpcwhitelistdefault=1", "")])
self.restart_node(0)
for permission in ["getbestblockhash", "getblockchaininfo"]: # Test whitelisted user (strangedude4)
self.log.info("[" + self.strange_users[6][0] + "]: Testing rpcwhitelistdefault=1 no specified permission (" + permission + ")") whitelisted_user = self.strange_users[4]
assert_equal(403, rpccall(self.nodes[0], self.strange_users[6], permission).status) assert_equal(200, rpccall(self.nodes[0], whitelisted_user, 'getblockcount').status)
assert_equal(403, rpccall(self.nodes[0], whitelisted_user, 'getbestblockhash').status)
# Test non-whitelisted user (strangedude6)
non_whitelisted_user = self.strange_users[6]
assert_equal(403, rpccall(self.nodes[0], non_whitelisted_user, 'getbestblockhash').status)
if __name__ == "__main__": if __name__ == "__main__":