mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-11-12 23:18:14 +01:00
Merge bitcoin/bitcoin#24378: refactor: make bind() and listen() mockable/testable
b2733ab6a8net: add new method Sock::Listen() that wraps listen() (Vasil Dimov)3ad7de225enet: add new method Sock::Bind() that wraps bind() (Vasil Dimov) Pull request description: _This is a piece of #21878, chopped off to ease review._ Add new methods `Sock::Bind()` and `Sock::Listen()` that wrap `bind()` and `listen()`. This will help to increase `Sock` usage and make more code mockable. ACKs for top commit: pk-b2: ACKb2733ab6a8laanwj: Code review ACKb2733ab6a8Tree-SHA512: c6e737606703e2106fe60cc000cfbbae3a7f43deadb25f70531e2cac0457e0b0581440279d14c76c492eb85c12af4adde52c30baf74542c41597e419817488e8
This commit is contained in:
@@ -155,6 +155,45 @@ int FuzzedSock::Connect(const sockaddr*, socklen_t) const
|
||||
return 0;
|
||||
}
|
||||
|
||||
int FuzzedSock::Bind(const sockaddr*, socklen_t) const
|
||||
{
|
||||
// Have a permanent error at bind_errnos[0] because when the fuzzed data is exhausted
|
||||
// SetFuzzedErrNo() will always set the global errno to bind_errnos[0]. We want to
|
||||
// avoid this method returning -1 and setting errno to a temporary error (like EAGAIN)
|
||||
// repeatedly because proper code should retry on temporary errors, leading to an
|
||||
// infinite loop.
|
||||
constexpr std::array bind_errnos{
|
||||
EACCES,
|
||||
EADDRINUSE,
|
||||
EADDRNOTAVAIL,
|
||||
EAGAIN,
|
||||
};
|
||||
if (m_fuzzed_data_provider.ConsumeBool()) {
|
||||
SetFuzzedErrNo(m_fuzzed_data_provider, bind_errnos);
|
||||
return -1;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
int FuzzedSock::Listen(int) const
|
||||
{
|
||||
// Have a permanent error at listen_errnos[0] because when the fuzzed data is exhausted
|
||||
// SetFuzzedErrNo() will always set the global errno to listen_errnos[0]. We want to
|
||||
// avoid this method returning -1 and setting errno to a temporary error (like EAGAIN)
|
||||
// repeatedly because proper code should retry on temporary errors, leading to an
|
||||
// infinite loop.
|
||||
constexpr std::array listen_errnos{
|
||||
EADDRINUSE,
|
||||
EINVAL,
|
||||
EOPNOTSUPP,
|
||||
};
|
||||
if (m_fuzzed_data_provider.ConsumeBool()) {
|
||||
SetFuzzedErrNo(m_fuzzed_data_provider, listen_errnos);
|
||||
return -1;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
std::unique_ptr<Sock> FuzzedSock::Accept(sockaddr* addr, socklen_t* addr_len) const
|
||||
{
|
||||
constexpr std::array accept_errnos{
|
||||
|
||||
Reference in New Issue
Block a user