highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-04 20:51:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

[net] Avoid initialization to a value that is never read

Browse Source 
Prior to this commit the value stored to `s` at initialization
was never read (in the case of STRERROR_R_CHAR_P).
This commit is contained in:
practicalswift
2017-01-12 22:51:26 +01:00
parent 7e2a2212ec
commit 5844609451
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/netbase.cpp
View File

@ -672,13 +672,14 @@ std::string NetworkErrorString(int err)
std::string NetworkErrorString(int err) std::string NetworkErrorString(int err)
{ {
char buf[256]; char buf[256];
const char *s = buf;
buf[0] = 0; buf[0] = 0;
/* Too bad there are two incompatible implementations of the /* Too bad there are two incompatible implementations of the
* thread-safe strerror. */ * thread-safe strerror. */
const char *s;
#ifdef STRERROR_R_CHAR_P /* GNU variant can return a pointer outside the passed buffer */ #ifdef STRERROR_R_CHAR_P /* GNU variant can return a pointer outside the passed buffer */
s = strerror_r(err, buf, sizeof(buf)); s = strerror_r(err, buf, sizeof(buf));
#else /* POSIX variant always returns message in buffer */ #else /* POSIX variant always returns message in buffer */
s = buf;
if (strerror_r(err, buf, sizeof(buf))) if (strerror_r(err, buf, sizeof(buf)))
buf[0] = 0; buf[0] = 0;
#endif #endif