highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-07 03:03:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replace some instances of formatWithUnit with formatHtmlWithUnit

Browse Source 
Strings in a HTML context should be using formatHtmlWithUnit.
This commit is contained in:
fanquake
2015-12-26 11:49:19 +08:00
parent be9a9a3d22
commit 5fdf32de7e
4 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/qt/bitcoinunits.cpp
View File

@@ -111,13 +111,6 @@ QString BitcoinUnits::format(int unit, const CAmount& nIn, bool fPlus, Separator
}
// TODO: Review all remaining calls to BitcoinUnits::formatWithUnit to
// TODO: determine whether the output is used in a plain text context
// TODO: or an HTML context (and replace with
// TODO: BtcoinUnits::formatHtmlWithUnit in the latter case). Hopefully
// TODO: there aren't instances where the result could be used in
// TODO: either context.
// NOTE: Using formatWithUnit in an HTML context risks wrapping
// quantities at the thousands separator. More subtly, it also results
// in a standard space rather than a thin space, due to a bug in Qt's