highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-01 00:10:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: remove confusing MAX_BLOCK_BASE_SIZE

Browse Source 
The constant `MAX_BLOCK_BASE_SIZE` has been removed from the
core implementation years ago due to being confusing and
superfluous, as it is implied by the block weight limit (see
PRs #10618 and #10608). Since there is also no point in
still keeping it in the functional test framework, we switch
to weight-based accounting on the relevant test code parts
and use `MAX_BLOCK_WEIGHT` instead for the block limit
checks.
This commit is contained in:
Sebastian Falbesoner
2021-07-01 01:43:45 +02:00
parent 4af97c74ed
commit 607076d01b
5 changed files with 35 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/functional/test_framework/messages.py
View File

@@ -32,7 +32,7 @@ from test_framework.siphash import siphash256
from test_framework.util import hex_str_to_bytes, assert_equal
MAX_LOCATOR_SZ = 101
MAX_BLOCK_BASE_SIZE = 1000000
MAX_BLOCK_WEIGHT = 4000000
MAX_BLOOM_FILTER_SIZE = 36000
MAX_BLOOM_HASH_FUNCS = 50