mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-03 22:03:01 +01:00
Do not invoke anti-DoS system for invalid BIP16 transactions
Doing so would allow an attack on old nodes, which would relay a standard transaction spending a BIP16 output in an invalid way, until reaching a new node, which will disconnect their peer. Reported by makomk on IRC.
This commit is contained in:
committed by
Luke Dashjr
parent
fea0a27ddc
commit
60f89779a3
@@ -1028,7 +1028,15 @@ bool CTransaction::ConnectInputs(MapPrevTx inputs,
|
||||
|
||||
// Verify signature
|
||||
if (!VerifySignature(txPrev, *this, i, fStrictPayToScriptHash, 0))
|
||||
{
|
||||
// only during transition phase for P2SH: do not invoke (external)
|
||||
// anti-DoS code for potentially old clients relaying bad P2SH
|
||||
// transactions
|
||||
if (fStrictPayToScriptHash && VerifySignature(txPrev, *this, i, false, 0))
|
||||
return error("ConnectInputs() : %s P2SH VerifySignature failed", GetHash().ToString().substr(0,10).c_str());
|
||||
|
||||
return error("ConnectInputs() : %s VerifySignature failed", GetHash().ToString().substr(0,10).c_str());
|
||||
}
|
||||
|
||||
// Mark outpoints as spent
|
||||
txindex.vSpent[prevout.n] = posThisTx;
|
||||
|
||||
Reference in New Issue
Block a user