highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-06 03:02:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

interfaces, gui: Remove is_mine output parameter from getAddress

Browse Source 
The is_mine output parameter is never used by any callers.
This commit is contained in:
Ava Chow
2025-05-15 17:27:44 -07:00
parent 22e689587a
commit 620abe985e
5 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/wallet/interfaces.cpp
View File

@@ -185,7 +185,6 @@ public:
}
bool getAddress(const CTxDestination& dest,
std::string* name,
isminetype* is_mine,
AddressPurpose* purpose) override
{
LOCK(m_wallet->cs_wallet);
@@ -194,16 +193,9 @@ public:
if (name) {
*name = entry->GetLabel();
}
std::optional<isminetype> dest_is_mine;
if (is_mine || purpose) {
dest_is_mine = m_wallet->IsMine(dest);
}
if (is_mine) {
*is_mine = *dest_is_mine;
}
if (purpose) {
// In very old wallets, address purpose may not be recorded so we derive it from IsMine
*purpose = entry->purpose.value_or(*dest_is_mine ? AddressPurpose::RECEIVE : AddressPurpose::SEND);
*purpose = entry->purpose.value_or(m_wallet->IsMine(dest) ? AddressPurpose::RECEIVE : AddressPurpose::SEND);
}
return true;
}