mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-25 22:39:13 +02:00
Merge #14599: Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. Remove the use of locale dependent boost::is_space(...)
8931a95becInclude util/strencodings.h which is required for IsSpace(...) (practicalswift)7c9f790761Update KNOWN_VIOLATIONS: Remove fixed violations (practicalswift)587924f000Use IsSpace(...) instead of boost::is_space (practicalswift)c5fd143edbUse ToLower(...) instead of std::tolower (practicalswift)e70cc8983cUse IsDigit(...) instead of std::isdigit (practicalswift) Pull request description: * Use `ToLower(...)` instead of `std::tolower`. `std::tolower` is locale dependent. * Use `IsDigit(...)` instead of `std::isdigit`. Some implementations (e.g. Microsoft in 1252 codepage) may classify single-byte characters other than `[0-9]` as digits. * Update `KNOWN_VIOLATIONS`: Remove fixed violations. * ~~Replace use of locale dependent Boost trim (`boost::trim`) with locale independent `TrimString`.~~ * Use` IsSpace(...)` instead of `boost::is_space` Tree-SHA512: defed016136b530b723fa185afdbd00410925a748856ba3afa4cee60f61a67617e30f304f2b9991a67b5fe075d9624f051e14342aee176f45fbc024d59e1aa82
This commit is contained in:
@@ -2,6 +2,7 @@
|
||||
// Distributed under the MIT software license, see the accompanying
|
||||
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
|
||||
#include <util/strencodings.h>
|
||||
#include <util/system.h>
|
||||
#include <test/test_bitcoin.h>
|
||||
|
||||
@@ -17,7 +18,7 @@ static void ResetArgs(const std::string& strArg)
|
||||
{
|
||||
std::vector<std::string> vecArg;
|
||||
if (strArg.size())
|
||||
boost::split(vecArg, strArg, boost::is_space(), boost::token_compress_on);
|
||||
boost::split(vecArg, strArg, IsSpace, boost::token_compress_on);
|
||||
|
||||
// Insert dummy executable name:
|
||||
vecArg.insert(vecArg.begin(), "testbitcoin");
|
||||
|
||||
Reference in New Issue
Block a user