highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-10-04 19:43:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: silence TSAN false positive in coinstatsindex_initial_sync

Browse Source 
Fixes https://github.com/bitcoin/bitcoin/issues/25365
This commit is contained in:
Vasil Dimov
2022-09-27 18:02:22 +02:00
parent 2e77dff744
commit 6526dc3b78
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/coinstatsindex_tests.cpp
View File

@@ -76,10 +76,16 @@ BOOST_FIXTURE_TEST_CASE(coinstatsindex_initial_sync, TestChain100Setup)
BOOST_CHECK(block_index != new_block_index); BOOST_CHECK(block_index != new_block_index);
// It is not safe to stop and destroy the index until it finishes handling
// the last BlockConnected notification. The BlockUntilSyncedToCurrentChain()
// call above is sufficient to ensure this, but the
// SyncWithValidationInterfaceQueue() call below is also needed to ensure
// TSAN always sees the test thread waiting for the notification thread, and
// avoid potential false positive reports.
SyncWithValidationInterfaceQueue();
// Shutdown sequence (c.f. Shutdown() in init.cpp) // Shutdown sequence (c.f. Shutdown() in init.cpp)
coin_stats_index.Stop(); coin_stats_index.Stop();
// Rest of shutdown sequence and destructors happen in ~TestingSetup()
} }
// Test shutdown between BlockConnected and ChainStateFlushed notifications, // Test shutdown between BlockConnected and ChainStateFlushed notifications,