highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 21:37:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

p2p: add validation check for initial self-announcement

Browse Source 
The direct send path for the initial self-announcement was bypassing
IsAddrCompatible() check that PushAddress() performs
This commit is contained in:
frankomosh
2026-01-15 11:17:18 +03:00
parent 9d2b8fddad
commit 6a8dbf9b93
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/net_processing.cpp
View File

@@ -5521,11 +5521,13 @@ void PeerManagerImpl::MaybeSendAddr(CNode& node, Peer& peer, std::chrono::micros
// Send the initial self-announcement in its own message. This makes sure // Send the initial self-announcement in its own message. This makes sure
// rate-limiting with limited start-tokens doesn't ignore it if the first // rate-limiting with limited start-tokens doesn't ignore it if the first
// message ends up containing multiple addresses. // message ends up containing multiple addresses.
std::vector<CAddress> self_announcement {local_addr}; if (IsAddrCompatible(peer, local_addr)) {
if (peer.m_wants_addrv2) { std::vector<CAddress> self_announcement{local_addr};
MakeAndPushMessage(node, NetMsgType::ADDRV2, CAddress::V2_NETWORK(self_announcement)); if (peer.m_wants_addrv2) {
} else { MakeAndPushMessage(node, NetMsgType::ADDRV2, CAddress::V2_NETWORK(self_announcement));
MakeAndPushMessage(node, NetMsgType::ADDR, CAddress::V1_NETWORK(self_announcement)); } else {
MakeAndPushMessage(node, NetMsgType::ADDR, CAddress::V1_NETWORK(self_announcement));
}
} }
} else { } else {
// All later self-announcements are sent together with the other addresses. // All later self-announcements are sent together with the other addresses.