highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-11 22:50:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't assert(foo()) where foo has side effects

Browse Source
This commit is contained in:
practicalswift
2018-06-26 17:19:31 +02:00
parent 0212187fc6
commit 6ad0328f1c
5 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/txvalidation_tests.cpp
View File

@@ -30,7 +30,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_reject_coinbase, TestChain100Setup)
coinbaseTx.vout[0].nValue = 1 * CENT;
coinbaseTx.vout[0].scriptPubKey = scriptPubKey;
assert(CTransaction(coinbaseTx).IsCoinBase());
BOOST_CHECK(CTransaction(coinbaseTx).IsCoinBase());
CValidationState state;