highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-19 05:12:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

coins, refactor: Assume state after SetClean in AddFlags to prevent dangling pointers

Browse Source 
Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
This commit is contained in:
Lőrinc 2024-10-31 13:33:36 +01:00
parent fc8c282022
commit 6b733699cf
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/coins.h
View File

@ -166,11 +166,13 @@ public:
{ {
Assume(flags & (DIRTY | FRESH)); Assume(flags & (DIRTY | FRESH));
if (!pair.second.m_flags) { if (!pair.second.m_flags) {
Assume(!pair.second.m_prev && !pair.second.m_next);
pair.second.m_prev = sentinel.second.m_prev; pair.second.m_prev = sentinel.second.m_prev;
pair.second.m_next = &sentinel; pair.second.m_next = &sentinel;
sentinel.second.m_prev = &pair; sentinel.second.m_prev = &pair;
pair.second.m_prev->second.m_next = &pair; pair.second.m_prev->second.m_next = &pair;
} }
Assume(pair.second.m_prev && pair.second.m_next);
pair.second.m_flags |= flags; pair.second.m_flags |= flags;
} }
static void SetDirty(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { AddFlags(DIRTY, pair, sentinel); } static void SetDirty(CoinsCachePair& pair, CoinsCachePair& sentinel) noexcept { AddFlags(DIRTY, pair, sentinel); }
@ -182,6 +184,7 @@ public:
m_next->second.m_prev = m_prev; m_next->second.m_prev = m_prev;
m_prev->second.m_next = m_next; m_prev->second.m_next = m_next;
m_flags = 0; m_flags = 0;
m_prev = m_next = nullptr;
} }
uint8_t GetFlags() const noexcept { return m_flags; } uint8_t GetFlags() const noexcept { return m_flags; }
bool IsDirty() const noexcept { return m_flags & DIRTY; } bool IsDirty() const noexcept { return m_flags & DIRTY; }