highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-25 00:31:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#25178: doc: remove passing --disable-external-signer in OpenBSD build guide

Browse Source 
9ecb0a3550 doc: remove passing `--disable-external-signer` in OpenBSD build guide (Sebastian Falbesoner)

Pull request description:

  Since we have a Boost.Process usage check in the build system (#24254, commit abc057c603), passing the option `--disable-external-signer` explicitly is not needed anymore on OpenBSD; the configure script will automatically detect that including `<boost/process.hpp>` leads to a compile error and disable external signer support accordingly:

  ```
  $ ./configure MAKE=gmake
  ...
  checking whether Boost.Process can be used... no
  ...
  Options used to compile and link:
    external signer = no
  ...

  $ ./configure --enable-external-signer MAKE=gmake
  ...
  checking whether Boost.Process can be used... no
  configure: error: External signing is not supported for this Boost version
  ```
  The PR basically reverts #22335 but keeps the part mentioning that external signer support is not available on OpenBSD. Also bumps the guide to version 7.1 (released [about a month ago](https://www.openbsd.org/71.html)), where I could verify that the instructions are still accurate.

ACKs for top commit:
  fanquake:
    ACK 9ecb0a3550

Tree-SHA512: a5f7e89a5a78f062a06e0047802c42ad49d89e0f0afb963886caa684966ea2e9c8a660320eedd98a5aa5eee0a9c2bb8bf7f5772338c4b49738a69c00e9367a15
This commit is contained in:
fanquake
2022-05-23 08:37:53 +02:00
parent b0e16eb3ac 9ecb0a3550
commit 6d20f4b920
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
doc/build-openbsd.md
View File

@@ -1,6 +1,6 @@
# OpenBSD Build Guide # OpenBSD Build Guide
**Updated for OpenBSD [7.0](https://www.openbsd.org/70.html)** **Updated for OpenBSD [7.1](https://www.openbsd.org/71.html)**
This guide describes how to build bitcoind, command-line utilities, and GUI on OpenBSD. This guide describes how to build bitcoind, command-line utilities, and GUI on OpenBSD.
@@ -78,12 +78,9 @@ export AUTOMAKE_VERSION=1.16
### 1. Configuration ### 1. Configuration
Note that building with external signer support currently fails on OpenBSD, Note that external signer support is currently not available on OpenBSD, since
hence you have to explicitly disable it by passing the parameter the used header-only library Boost.Process fails to compile (certain system
`--disable-external-signer` to the configure script. The feature requires the calls and preprocessor defines like `waitid()` and `WEXITED` are missing).
header-only library boost::process, which is available on OpenBSD, but contains
certain system calls and preprocessor defines like `waitid()` and `WEXITED` that
are not available.
There are many ways to configure Bitcoin Core, here are a few common examples: There are many ways to configure Bitcoin Core, here are a few common examples:
@@ -91,14 +88,14 @@ There are many ways to configure Bitcoin Core, here are a few common examples:
This enables the GUI and descriptor wallet support, assuming `sqlite` and `qt5` are installed. This enables the GUI and descriptor wallet support, assuming `sqlite` and `qt5` are installed.
```bash ```bash
./configure --disable-external-signer MAKE=gmake ./configure MAKE=gmake
``` ```
##### Descriptor & Legacy Wallet. No GUI: ##### Descriptor & Legacy Wallet. No GUI:
This enables support for both wallet types and disables the GUI: This enables support for both wallet types and disables the GUI:
```bash ```bash
./configure --disable-external-signer --with-gui=no \ ./configure --with-gui=no \
BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \ BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \
BDB_CFLAGS="-I${BDB_PREFIX}/include" \ BDB_CFLAGS="-I${BDB_PREFIX}/include" \
MAKE=gmake MAKE=gmake