highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-11 21:20:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

psbt: remove write-only global xpub tracking set

Browse Source 
The explicit duplicate global xpub check was replaced by the generic
duplicate key check in 1e2d146b47, leaving the set unused.
This commit is contained in:
Thomas
2026-06-12 08:03:42 +02:00
parent 3b7051c7e3
commit 6d387af562
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/psbt.h
View File

@@ -1360,9 +1360,6 @@ public:
// Used for duplicate key detection // Used for duplicate key detection
std::set<std::vector<unsigned char>> key_lookup; std::set<std::vector<unsigned char>> key_lookup;
// Track the global xpubs we have already seen. Just for sanity checking
std::set<CExtPubKey> global_xpubs;
// Read global data // Read global data
bool found_sep = false; bool found_sep = false;
std::optional<CMutableTransaction> tx; std::optional<CMutableTransaction> tx;
@@ -1465,7 +1462,6 @@ public:
if (!xpub.pubkey.IsFullyValid()) { if (!xpub.pubkey.IsFullyValid()) {
throw std::ios_base::failure("Invalid pubkey"); throw std::ios_base::failure("Invalid pubkey");
} }
global_xpubs.insert(xpub);
// Read in the keypath from stream // Read in the keypath from stream
KeyOriginInfo keypath; KeyOriginInfo keypath;
DeserializeHDKeypath(s, keypath); DeserializeHDKeypath(s, keypath);