highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-13 19:26:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: removes unnecessary check from validation_tests

Browse Source 
An unnecessary check was added to the block mutation tests
in #29412 where IsBlockMutated is returning true for the invalid
reasons: we try to check mutation via transaction duplication,
but the merkle root is not updated before the check, therefore
the check fails because the provided root and the computed root
differ, but not because the block contains the same transaction twice.

The check is meaningless so it can be removed.
This commit is contained in:
Sergi Delgado Segura
2024-02-29 09:54:47 -05:00
parent 2649e655b9
commit 6ee3997d03
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/validation_tests.cpp
View File

@ -233,7 +233,6 @@ BOOST_AUTO_TEST_CASE(block_malleation)
// Block with two transactions is mutated if any node is duplicate.
{
block.vtx[1] = block.vtx[0];
BOOST_CHECK(is_mutated(block, /*check_witness_root=*/false));
HashWriter hasher;
hasher.write(block.vtx[0]->GetHash());
hasher.write(block.vtx[1]->GetHash());