highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-10 05:57:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

wallet: notify when preset + automatic inputs exceed max weight

Browse Source 
This also avoids signing all inputs prior to erroring out.
This commit is contained in:
furszy
2024-06-19 14:27:35 -03:00
parent 2d21060af8
commit 72b226882f
3 changed files with 74 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/functional/wallet_fundrawtransaction.py
View File

@@ -114,6 +114,7 @@ class RawTransactionsTest(BitcoinTestFramework):
self.test_add_inputs_default_value()
self.test_preset_inputs_selection()
self.test_weight_calculation()
self.test_weight_limits()
self.test_change_position()
self.test_simple()
self.test_simple_two_coins()
@@ -1312,6 +1313,38 @@ class RawTransactionsTest(BitcoinTestFramework):
self.nodes[2].unloadwallet("test_weight_calculation")
def test_weight_limits(self):
self.log.info("Test weight limits")
self.nodes[2].createwallet("test_weight_limits")
wallet = self.nodes[2].get_wallet_rpc("test_weight_limits")
outputs = []
for _ in range(1472):
outputs.append({wallet.getnewaddress(address_type="legacy"): 0.1})
txid = self.nodes[0].send(outputs=outputs)["txid"]
self.generate(self.nodes[0], 1)
# 272 WU per input (273 when high-s); picking 1471 inputs will exceed the max standard tx weight.
rawtx = wallet.createrawtransaction([], [{wallet.getnewaddress(): 0.1 * 1471}])
# 1) Try to fund transaction only using the preset inputs
input_weights = []
for i in range(1471):
input_weights.append({"txid": txid, "vout": i, "weight": 273})
assert_raises_rpc_error(-4, "Transaction too large", wallet.fundrawtransaction, hexstring=rawtx, input_weights=input_weights)
# 2) Let the wallet fund the transaction
assert_raises_rpc_error(-4, "The inputs size exceeds the maximum weight. Please try sending a smaller amount or manually consolidating your wallet's UTXOs",
wallet.fundrawtransaction, hexstring=rawtx)
# 3) Pre-select some inputs and let the wallet fill-up the remaining amount
inputs = input_weights[0:1000]
assert_raises_rpc_error(-4, "The combination of the pre-selected inputs and the wallet automatic inputs selection exceeds the transaction maximum weight. Please try sending a smaller amount or manually consolidating your wallet's UTXOs",
wallet.fundrawtransaction, hexstring=rawtx, input_weights=inputs)
self.nodes[2].unloadwallet("test_weight_limits")
def test_include_unsafe(self):
self.log.info("Test fundrawtxn with unsafe inputs")