test: Correct ineffectual WithOrVersion from transactions_tests

WithOrVersion uses | to combine the versions, and | with 0 is a no-op.

Instead I run it with PROTOCOL_VERSION and 0 separately, as the original
code only tested PROTOCOL_VERSION but apparently only intended to test
version 0.

Introduced in ab48c5e721
Last updated 81e3228fcb
This commit is contained in:
Ben Woosley
2018-12-02 01:56:12 -08:00
parent ed12fd83ca
commit 75778a0724
2 changed files with 4 additions and 10 deletions

View File

@@ -64,12 +64,6 @@ public:
size_t size() const { return stream->size(); }
};
template<typename S>
OverrideStream<S> WithOrVersion(S* s, int nVersionFlag)
{
return OverrideStream<S>(s, s->GetType(), s->GetVersion() | nVersionFlag);
}
/* Minimal stream for overwriting and/or appending to an existing byte vector
*
* The referenced vector will grow as necessary